oklas / react-app-alias

:label: Alias and multiple src directory for craco or rewired create-react-app
MIT License
174 stars 18 forks source link

Fix #95: Address Jest moduleDirectories Behavior #96

Closed bryanculver closed 1 year ago

bryanculver commented 1 year ago

Close #95

oklas commented 1 year ago

Issue with wasm https://github.com/oklas/react-app-alias/issues/95#issuecomment-1500425525 here above is solved. But issue with import is not reproducing to me.

codecov-commenter commented 1 year ago

Codecov Report

Merging #96 (93ed325) into master (2f842ee) will increase coverage by 7.57%. The diff coverage is 31.01%.

:exclamation: Current head 93ed325 differs from pull request most recent head 46a66f8. Consider uploading reports for the commit 46a66f8 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
+ Coverage   23.43%   31.01%   +7.57%     
==========================================
  Files           2        2              
  Lines         320      403      +83     
  Branches        1       12      +11     
==========================================
+ Hits           75      125      +50     
- Misses        245      278      +33     
Impacted Files Coverage Δ
packages/react-app-alias-ex/src/index.js 28.22% <28.22%> (+0.29%) :arrow_up:
packages/react-app-alias/src/index.js 32.91% <32.91%> (+13.63%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

oklas commented 1 year ago

Tried to rollback #97. It appears breaking. Need to inspect.

oklas commented 1 year ago

As I wrote above the error in ci is not reproduced locally

bryanculver commented 1 year ago

As I wrote above the error in ci is not reproduced locally

Thanks. I have time on Monday to reproduce this and maybe get a sample project to demonstrate