search

okleine / nCoAP

Java implementation of the CoAP protocol using netty
BSD 3-Clause "New" or "Revised" License
179 stars 57 forks source link

add block2 message option #25

Closed Jiloc closed 9 years ago

okleine commented 9 years ago

Thanks for your effort! I think, its a good idea to implement the blockwise extension. However, your pull request is only about the block 2 option and without any further logic, i.e. separation and re-composition of messages . The pure presence of the option may be misleading because as a user one would assume more. Would you consider implementing the blockwise extension as a whole? Unfortunatly I didn't have the time to do it, yet.

okleine commented 9 years ago

I will take your additions as a basis for rudimentary support for the block2 option (on the client side only until further notice). Thank you again!

Jiloc commented 9 years ago

Thank YOU for starting this project and excuse me but i forgot about this merge request and i did not answer! Il 08/mag/2015 17:24, "Oliver Kleine" notifications@github.com ha scritto:

I will take your additions as a basis for rudimentary support for the block2 option (on the client side only until further notice). Thank you again!

— Reply to this email directly or view it on GitHub.

okleine commented 9 years ago

You might want to have a look at the "blockwise" branch. I added rather simple support for blockwise transfer on the client side. A client always accepts the blocksize that was given by the server (in its first response). Upon reception of the first block the client requests further blocks automatically. The ClientCallback is invoked upon reception of the complete payload.