okleinschmidt / wdmc

The missing CLI Client for Western Digital MyCloud NAS Systems.
MIT License
14 stars 3 forks source link

Revert "Add test support" #10

Closed okleinschmidt closed 6 years ago

okleinschmidt commented 6 years ago

Reverts okleinschmidt/wdmc#9

Not working for me?

$ bundle exec rspec

An error occurred while loading ./spec/client_spec.rb.
Failure/Error: hash_w_symbol_keys(['get_acl', share_w_acl])

NameError:
  undefined local variable or method `share_w_acl' for #<Class:0x00007f8142092868>
# ./spec/client_spec.rb:75:in `block (3 levels) in <top (required)>'
# ./spec/client_spec.rb:73:in `block (2 levels) in <top (required)>'
# ./spec/client_spec.rb:60:in `block in <top (required)>'
# ./spec/client_spec.rb:4:in `<top (required)>'

Finished in 0.00031 seconds (files took 0.4797 seconds to load)
0 examples, 0 failures, 1 error occurred outside of examples
tdilauro commented 6 years ago

Oh, I know what's wrong here. I have a .rspec with:

--require spec_helper

That picks up the definitions in ./spec/spec_helper.rb.

There is another potential issue that you (or someone else) might run into, as well: The viability of that particular test depends at least two properties of the share named in the share_w_acl variable in ./spec/spec_helper.rb:

This test needs to be more robust and more easily configurable. I'll think about a way to do it better. In the mean time, I'll resubmit a new PR with this test commented out and with the .rspec file included.