okmr-d / DOFavoriteButton

Cute Animated Button written in Swift.
MIT License
3.61k stars 297 forks source link

Began Swift 3 conversion, outstanding issues with isSelected #27

Open martin-grindr opened 8 years ago

siideffect commented 8 years ago

Hi martin, thanks for the conversion first of all, i use this library on one of my apps on the appstore, so i really needed it. So, you reported some problem with the isSelected variable ( i used your source code, and i experienced problems in my app, and i was not able to deselect the DoFavouriteButton), but after digging into the code, i could notice you (for some reason ) commented out the first line of select() and deselect() methods, which were setting the button selected state.

Actually i am using it in my project and is fully compatible with swift 3, i just had small problems with the cgpath methods, which can be easily solved: moveTo becomes move( to: CGPoint() ) addLineTo becomes addLine( to: CGPoint() )

Hope it helps, enjoy coding =)