search

okmr-d / DOFavoriteButton

Cute Animated Button written in Swift.
MIT License
3.61k stars 297 forks source link

Swift3 update #34

Open indrajitsinh opened 8 years ago

indrajitsinh commented 8 years ago

Swift3

ph1ps commented 8 years ago

@indrajitsinh I just noticed that there are already 4 PRs for Swift 3 support. Since the developer is inactive and probably won't accept the PRs, should we just remove this item from the list at https://github.com/vsouza/awesome-ios and add a fork of ours? I'm just asking (also I'm assuming that you found that repository there) because it doesn't quite fit into the criteria at https://github.com/vsouza/awesome-ios/blob/master/.github/CONTRIBUTING.md. Also I find it a real shame if this repository couldn't be used anymore without converting and fixing bugs. Maybe you could drop a opinion and I'm tagging you because you have the most recent PR. Thanks!

seemakamath commented 8 years ago

@indrajitsinh Please don't use the commits from my branch to open a new PR. There is another PR in progress already https://github.com/okmr-d/DOFavoriteButton/pull/30 that you should use (which is why I closed my PR in the first place).

ph1ps commented 8 years ago

@seemakamath #30 is actually not a working build thats why I submitted #35 . Did you try building and running it?

seemakamath commented 8 years ago

@ph1ps Can you provide more details in terms of what's not working? Have you checked out this comment? https://github.com/okmr-d/DOFavoriteButton/pull/30#issuecomment-247398348

kiwo12345 commented 8 years ago

@seemakamath https://github.com/okmr-d/DOFavoriteButton/pull/30 does not work. Adding self.layoutIfNeeded() as mentioned in one of the comments will mess upp the constraints

seemakamath commented 8 years ago

@kiwo12345 Regardless, let's help get #30 merged by giving feedback there.