oknozor / illumination

A mardown renderer for nvim written with gtkrs and neovim-lib
GNU General Public License v3.0
84 stars 6 forks source link

Error building illumination #17

Closed do-you-dare closed 4 years ago

do-you-dare commented 4 years ago

Hello! I'm trying to use this on Fedora 30, and this is the error I get:

➜  .illumination git:(master) ✗ cargo build     
   Compiling illumination v0.2.0 (/home/esilva/.illumination)
error[E0277]: the trait bound `gio::auto::cancellable::Cancellable: glib::object::IsA<gio::auto::cancellable::Cancellable>` is not satisfied
   --> src/ui/app.rs:121:39
    |
121 |     webview.run_javascript(js_scroll, None::<&gio::Cancellable>, move |msg| {
    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `glib::object::IsA<gio::auto::cancellable::Cancellable>` is not implemented for `gio::auto::cancellable::Cancellable`

error[E0277]: the trait bound `webkit2gtk::auto::web_view::WebView: glib::object::IsA<gtk::Widget>` is not satisfied
  --> src/ui/content.rs:16:25
   |
16 |         container.pack1(&preview, true, true);
   |                         ^^^^^^^^ the trait `glib::object::IsA<gtk::Widget>` is not implemented for `webkit2gtk::auto::web_view::WebView`

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0277`.
error: could not compile `illumination`.

To learn more, run the command again with --verbose.

The rust version is 1.40.0.

Thanks, nice project!

cosmoduff commented 4 years ago

I got it to compile by changing Cargo.toml back to commit 8845abfe1e83e005830e5d375a9cbc4861a2bdb3. Seems it could be an issue with the GTK feature flags that were added.

do-you-dare commented 4 years ago

Thanks! While changing only the Cargo.toml back didn't work for me, checking out to that commit I could get it to build. Not optimal, but it works.

cosmoduff commented 4 years ago

@dread-uo I fixed the build errors and submitted a pull request. It should work on Fedora as well.

oknozor commented 4 years ago

Thank you @cosmoduff! I am closing this for it seems to be fixed.