search

oknozor / musicbrainz_rs

A wrapper around the musicbrainz API
MIT License
38 stars 18 forks source link

feat: implement search for release-groups #57

Closed oknozor closed 3 years ago

codecov-commenter commented 3 years ago

Codecov Report

Merging #57 (658ecc0) into main (648215a) will decrease coverage by 0.01%. The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
- Coverage   86.62%   86.61%   -0.02%     
==========================================
  Files          46       47       +1     
  Lines        1234     1248      +14     
==========================================
+ Hits         1069     1081      +12     
- Misses        165      167       +2
Impacted Files Coverage Δ
src/config.rs 87.80% <ø> (ø)
src/entity/artist.rs 86.66% <0.00%> (-13.34%) :arrow_down:
src/entity/mod.rs 65.97% <ø> (ø)
src/entity/release.rs 90.90% <ø> (ø)
src/entity/release_group.rs 100.00% <ø> (ø)
src/lib.rs 55.23% <ø> (ø)
src/deserialization/date_format.rs 100.00% <100.00%> (ø)
tests/artist/artist_search.rs 100.00% <100.00%> (ø)
tests/release_group/release_group_search.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 648215a...658ecc0. Read the comment docs.

oknozor commented 3 years ago

@ritiek I started to build a showcase app to test the library. Turns out I had to implement at least release group search in order to use the coverart feature you implemented. Fetching cover arts works great but implementing search on release group brought several problems up :

I think we should not merge this (or any other serach implementation) until we come up with a solution to replace the query builder.

ritiek commented 3 years ago

@oknozor Is something holding this PR from getting merged? Anything I can help you with?