search

oknozor / musicbrainz_rs

A wrapper around the musicbrainz API
MIT License
38 stars 18 forks source link

feat(release): support `artist_credits` subquery #75

Closed snylonue closed 2 years ago

snylonue commented 2 years ago

I found artist information is not included when fetching a release and adding artist-credits(or artists) to subquery fixes that. This pr adds with_artist_credits to Release.

Yesterday17 commented 2 years ago

I've upgraded reqwest to 0.11 and added feature rustls to disable openssl for MUSL builds. Some test cases are also fixed according to the actual return value of the API.

oknozor commented 2 years ago

Hey, thanks for the PR and sorry for the delay, I will take a closer look tomorrow.

oknozor commented 2 years ago

Hey, it's all good except for the clippy lints, I'll merge this once those are fixed.

Yesterday17 commented 2 years ago

it's all good except for the clippy lints

Done

oknozor commented 2 years ago

it's all good except for the clippy lints

Done

Seems there are still some lints spotted by clippy

Yesterday17 commented 2 years ago

Seems there are still some lints spotted by clippy

Upgrade local environment and there's no error on my computer.

Yesterday17 commented 2 years ago

Any updates?

Yesterday17 commented 1 year ago

Seems it's not released?