oknozor / musicbrainz_rs

A wrapper around the musicbrainz API
MIT License
38 stars 18 forks source link

Pagination support #79

Closed nappa85 closed 1 year ago

nappa85 commented 1 year ago
codecov-commenter commented 1 year ago

Codecov Report

Merging #79 (3ca8149) into main (9c5327d) will decrease coverage by 0.75%. The diff coverage is 68.57%.

@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
- Coverage   74.70%   73.95%   -0.75%     
==========================================
  Files          29       29              
  Lines         917      937      +20     
==========================================
+ Hits          685      693       +8     
- Misses        232      244      +12     
Impacted Files Coverage Δ
src/lib.rs 61.22% <59.25%> (-2.42%) :arrow_down:
src/config.rs 89.55% <100.00%> (ø)
src/deserialization/date_format.rs 100.00% <100.00%> (ø)
src/entity/mod.rs 80.13% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

nappa85 commented 1 year ago

Let me know if there is something more I can do, I don't know if the 0.75% loss in code coverage is a game stopper

oknozor commented 1 year ago

Let me know if there is something more I can do, I don't know if the 0.75% loss in code coverage is a game stopper

Hey @nappa85, not at all, less than 1% decrease in coverage is negligible. This is a welcome change.

oknozor commented 1 year ago

This as just been released, seems there was a bug with the changelog tool, sorry to all the people getting undesired notification :(