search

okonek / tidal-cli-client

You can now use Tidal on linux. With your loved CLI. <3
MIT License
272 stars 29 forks source link

Crash when searching for artist "MASTER BOOT RECORD" #14

Closed deadcombo closed 6 years ago

deadcombo commented 6 years ago 
             (node:29790) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'replace' of null                                                                                                                                                                   
    at TidalApi.TidalAPI.getArtURL (/usr/lib/node_modules/tidal-cli-client/node_modules/tidalapi/lib/client.js:342:53)
    at Promise (/usr/lib/node_modules/tidal-cli-client/app/Artist.js:20:36)                                                            
    at new Promise (<anonymous>)                                                                                                                                                                                                                                               
    at Artist.updateArt (/usr/lib/node_modules/tidal-cli-client/app/Artist.js:18:16)                                                                                                                                                                                           
    at Object.communicationEvents.subscribe [as handler] (/usr/lib/node_modules/tidal-cli-client/app/UI/MainScreen.js:100:34)                                                                                                                                                  
    at Observable.fire (/usr/lib/node_modules/tidal-cli-client/app/Observable.js:45:37)                                                                                                                                                                                        
    at module.exports.on (/usr/lib/node_modules/tidal-cli-client/app/UI/ArtistsList.js:13:38)                                                                                                                                                                                  
    at module.exports.EventEmitter._emit (/usr/lib/node_modules/tidal-cli-client/node_modules/blessed/lib/events.js:98:20)                                                                                                                                                     
    at module.exports.EventEmitter.emit (/usr/lib/node_modules/tidal-cli-client/node_modules/blessed/lib/events.js:117:12)                                                                                                                                                     
    at module.exports.List.enterSelected (/usr/lib/node_modules/tidal-cli-client/node_modules/blessed/lib/widgets/list.js:586:8)                                                                                                                                               
(node:29790) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 3)                       │
(node:29790) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

That's what it spews out after I hit return.

To replicate:

  1. Run tidal-cli

  2. Input :

  3. Input artist

  4. Input full or partial query "MASTER BOOT RECORD"

  5. Press RETURN

That`s pretty much it.

okonek commented 6 years ago

Thank's for your feedback, I'll try to repair it as soon as possible.

okonek commented 6 years ago

It was an issue with that app couldn't find artist image, because MASTER BOOT RECORD doesn't have one in Tidal. Now it displays the default image from Tidal. Closing