okonek / tidal-cli-client

You can now use Tidal on linux. With your loved CLI. <3
MIT License
272 stars 29 forks source link

Playlists in collection not created by user are not listed #72

Open ChrisRenfrow opened 5 years ago

ChrisRenfrow commented 5 years ago

Hey there! First of all, thanks okonek for making this project. I'm in the middle of migrating from YouTube Music to TIDAL and being a developer I like to keep things in the terminal as much as possible to prevent distraction, etc. That being said, your project caught my eye and I've been using it while I work today.

Now, on to the issue.

I have a number of playlists created by TIDAL (or another "user" e.g. "Serato") that I have saved to my collection/favorites for easy access. Listing my playlists in your CLI only shows the playlists I have created rather than all the playlists in my collection/favorites including my own playlists as the web client does.

After some digging around, it seems you have some methods in your wrapper that would help with this. I would suggest that the results from the wrapper's getFavoritePlaylists() method be included when the user asks for their playlists. Perhaps even as a configurable opt-out setting, as it may be confusing to new users why playlists they've added don't show up when they list their playlists.

If you like, I could do this on my own fork and make a PR for you to review.

Thanks for your time. :slightly_smiling_face: