okonek / tidal-cli-client

You can now use Tidal on linux. With your loved CLI. <3
MIT License
272 stars 29 forks source link

keyboard text input has no effect on login screen #73

Open amblabs opened 5 years ago

amblabs commented 5 years ago

Just installed tidal-cli-client. When I start tidal-cli, the login screen appears, and I can use the tab key to move between fields. But when I type my user name or password, nothing is echoed, and nothing appears in the field. When I tab to the "Login" button, it tells me to enter the user name and password.

This is on openSUSE Leap 15.0, in an xterm window (also tried Konsole with the same issue). tidal-cli-client was installed with "npm -g i tidal-cli-client@latest". I have MPV and W3M:

$ rpm -q mpv w3m mpv-0.27.2-lp150.4.2.x86_64 w3m-0.5.3+git20180125-lp150.1.3.x86_64

watzon commented 5 years ago

Also having this issue after installing from AUR on Arch

WillAndersonWA commented 5 years ago

You have to press enter on the field in order to start typing. I just tried it out myself, though I don't have w3m-img configured.

amblabs commented 5 years ago

Ah, ok. That wasn't intuitive. I was now able to get past the login screen, but then I'm stuck on the next screen (copy paypal or bitcoin address to donate). I can tab to the two fields, or to a seemingly unshown field, but nothing else I press (space bar, enter, arrow keys, or any character) seem to do anything, and what I type is not echoed on screen either. The box on the bottom says "No track'.

amblabs commented 5 years ago

Update: If I press F2, then the "command line" seems to get focus and gives me "search ". I can then backspace over the search to type other commands. But shouldn't I be able to type commands without doing this "workaround"?

WillAndersonWA commented 5 years ago

Use the : key in order to set you into the input box, it's incredibly unintuitive if you're not used to vim, I'll probably start writing some PR's in order to make it more usable for most people.

WillAndersonWA commented 5 years ago

Check this video for more imformation

When I pressed Enter after a few seconds the song started playing, everything working as intended

amblabs commented 5 years ago

OK, the : key worked, thanks. Sigh, the documentation on this site doesn't mention any of this. I am a vi(m) user but it wasn't obvious to me that I had to use the : key in order to type commands.

I can search for albums and songs, etc., and get to my playlists. But how about my collection? There doesn't seem to be a command for that.

amblabs commented 5 years ago

Also, there is no "logout" command. Since the stream quality was selected before login, currently there is no way to change that once logged in. Quitting the application doesn't log me out.

WillAndersonWA commented 5 years ago

You won't need to log out, you can edit it in ~/.config/tidal-cli-client/credentials.json though @okonek storing passwords in plain text in ~/.config isn't considered a safe practice, many people just dump their .config file in their dotfiles repo and leave it as that, easily exposing passwords.

amblabs commented 5 years ago

OK, I guess this app is barebones, lol. I agree with @TheGamingBarrel that storing the password in plain text is not secure. @okonek How about at least encrypting it as in the /etc/shadow file and keep the the perms read/write only for the owner?