okp4 / ui

🎨 Implementation of OKP4 UI components in React, TypeScript, and SASS.

https://ui.okp4.space/

BSD 3-Clause "New" or "Revised" License

28 stars 2 forks source link

Feat: change mandatory firstElement property to optional #573

Closed lolottetheclash closed 1 year ago

lolottetheclash commented 2 years ago

This PR makes the firstElement property optional because there was no reason to force the user to provide this property. The Header no longer has any mandatory properties. 🛠 The css has been completely reworked to facilitate the possible extension of the Header properties: 👉 if we plan to add a Login element in JSX, this addition will not force us to modify the existing but to add a behavior.

codecov-commenter commented 2 years ago

Codecov Report

Merging #573 (cccda9e) into main (41f330c) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #573   +/-   ##
=======================================
  Coverage   96.73%   96.73%           
=======================================
  Files          74       74           
  Lines         950      950           
  Branches      146      146           
=======================================
  Hits          919      919           
  Misses         29       29           
  Partials        2        2

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

lolottetheclash commented 1 year ago

I am closing this PR because it is no longer relevant.