okpy / ok-client

A Python client for the OK autograding system
https://okpy.org/
Apache License 2.0
57 stars 42 forks source link

Files should be submitted even if importing fails #367

Open albertkx opened 5 years ago

albertkx commented 5 years ago

Some students have run into issues where they have top-level syntax errors, i.e. indentation issues, that prevent their assignment file from being imported. This also prevents ok client from submitting the file.

image

We should have ok client submit the assignment file to okpy even if top-level syntax errors cause local testing to error, so we have a submission which we can regrade.

ja5087 commented 5 years ago

Will look into this

ja5087 commented 5 years ago

The issue is due to how the client imports all dependencies listed in the config.ok file to build the Assignments object, then errors since the test file cannot be loaded as a module. I will look into writing it so the code only loads the tests as the doctests protocol is run so other protocols (namely, backup) can still run.