search

okpy / ok

ok.py supports programming projects by running tests, tracking progress, and assisting in debugging.
Apache License 2.0
336 stars 84 forks source link

Protect against set but empty OAuth variables #1292

Closed c-w closed 6 years ago

c-w commented 6 years ago

Currently we're only checking whether the variables like GOOGLE_ID or MICROSOFT_APP_SECRET are set as environment variables but we aren't validating whether the variables are non-empty. This means that the server start might be successful but we'll fail later at login time which is harder to debug. This change fixes that behavior and prevents server start if the OAuth variables are set but contain empty values.

c-w commented 6 years ago

@liliankasem @cicorias FYI

liliankasem commented 6 years ago

@c-w thanks for cleaning up!