search

okpy / ok

ok.py supports programming projects by running tests, tracking progress, and assisting in debugging.
Apache License 2.0
333 stars 84 forks source link

Navigate to index page after OK logo clicked in staff mode #1345

Closed Royserg closed 5 years ago

Royserg commented 5 years ago

Instead of getting assignments page, navigate to the student mode index page. My first contribution to OS, not sure if I did it right 🤞🤞

fix #1344

colinschoen commented 5 years ago

The issue @pbitutsky filed suggests one of the places the header can link to is the student index. I don't think this is super useful. I think we should just link to the list of courses (in the staff view) for everyone (not just admins).

pbitutsky commented 5 years ago

@colinschoen If I'm understanding you correctly, you would like for the OK logo to navigate to http://localhost:5000/admin/course/. However, there is already navigation to get there: in the navbar, under courses > View All Courses. However, there is no way to navigate to the student index (http://localhost:5000/) via the UI. So won't it be better if the logo were to navigate to the student index?

colinschoen commented 5 years ago

@pbitutsky Ah, ok that does sound ok too. Yeah navigating to the student index makes sense.