search

okpy / ok

ok.py supports programming projects by running tests, tracking progress, and assisting in debugging.
Apache License 2.0
333 stars 84 forks source link

Add form in Student View for editing enrollment information #1346

Closed pbitutsky closed 5 years ago

pbitutsky commented 5 years ago

This resolves issue #1274.

I've added a form to the student view that allows admin/staff to edit information about students like their name, SID, secondary auth, section, and role. Users cannot, however, change students' email addresses since much of the back-end code relies on using the email as an identifier. Maybe this could be a feature in the future.

screen shot 2019-01-16 at 12 30 51 am screen shot 2019-01-16 at 12 30 55 am screen shot 2019-01-16 at 12 31 37 am screen shot 2019-01-16 at 12 31 45 am
colinschoen commented 5 years ago

Awesome work. I’ll review tomorrow.

On Tue, Jan 15, 2019 at 21:44 Paul Bitutsky notifications@github.com wrote:

This resolves issue #1274 https://github.com/okpy/ok/issues/1274.

I've added a form to the student view that allows admin/staff to edit information about students like their name, SID, secondary auth, section, and role. Users cannot, however, change students' email addresses since much of the back-end code relies on using the email as an identifier. Maybe this could be a feature in the future.

[image: screen shot 2019-01-16 at 12 30 51 am] https://user-images.githubusercontent.com/6360587/51228670-6a56c080-1927-11e9-802e-23cc8a931a1c.png

[image: screen shot 2019-01-16 at 12 30 55 am] https://user-images.githubusercontent.com/6360587/51228694-7f335400-1927-11e9-8911-da38132043dd.png

[image: screen shot 2019-01-16 at 12 31 37 am] https://user-images.githubusercontent.com/6360587/51228700-85293500-1927-11e9-8be8-da642eb1c949.png

[image: screen shot 2019-01-16 at 12 31 45 am] https://user-images.githubusercontent.com/6360587/51228704-88242580-1927-11e9-9828-9b6ead8c18ec.png

You can view, comment on, or merge this pull request online at:

https://github.com/okpy/ok/pull/1346 Commit Summary

  • Add form in Student View for editing enrollment information

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/okpy/ok/pull/1346, or mute the thread https://github.com/notifications/unsubscribe-auth/ACysaoL_0fTI1aUo1GSWbAnpnVusKwILks5vDrwqgaJpZM4aCW2N .

colinschoen commented 5 years ago

This might also be a nice opportunity for a test, but I won't hold you to it if you want to get it shipped now :).