Closed simon-mo closed 5 years ago
I can review this tomorrow.
Looks good to me. (But I hope Colin reviews too, since I've never actually edited this code base before.)
I’ll be back and can take a look in a couple hours. I’ll definitely get to it tonight.
@colinschoen Thanks! Comments are addressed. I still kept the AUTOGRADER_URL
constants so models.py
won't get affected.
@colinschoen Tests passed now
@colinschoen Thanks for reviewing! Can you take another look? The first assignments that need this change have been submitted, so we're waiting to grade them.
Yes! I’ll take another pass in an hour
I'll cut a new version and deploy this tonight.
cc @papajohn
This feature is needed for DS100 (maybe Data 8) this semester (we need to start grading this week). If this can merged ASAP, it would be great! Please let me know if there's anything I can do to expedite this process.
Why another autograder
In DS100, many homework requires large dataset hosted on our datahub cluster. In addition, these assignment also require large amount of memory to work with. It would save both our time and the okpy deployment team's resource if we cleanly separate them.