search

okraits / j4-make-config

Universal theme switcher and config generator for the i3 wm
http://www.okraits.de/index.php?section=projects&page=j4-make-config
185 stars 22 forks source link

Implemented argparse; added some functions; changed tabs to spaces. #15

Open D-Vaillant opened 6 years ago

D-Vaillant commented 6 years ago

The tabs to spaces thing is, arguably, an aesthetic difference but it is PEP8. Adding in argparse lets us change the RC file loading from running a system command. I tried to keep it essentially identical in functionality to the original version but it's fairly easy to, say, jettison the requirement for none when we want to do things without using a theme.

lasers commented 6 years ago

Bug.

Expected:

  ~/src/j4-make-config   master  ./j4-make-config
Executing: ./j4-make-config none
  ~/src/j4-make-config   master  ./j4-make-config
Executing: ./j4-make-config none
  ~/src/j4-make-config   master  ./j4-make-config
Executing: ./j4-make-config none
  ~/src/j4-make-config   master  ./j4-make-config

Got:

  ~/src/j4-make-config   D-Vaillant-argparse  ./j4-make-config none
  ~/src/j4-make-config   D-Vaillant-argparse  ./j4-make-config
Executing: ./j4-make-config none
  ~/src/j4-make-config   D-Vaillant-argparse  ./j4-make-config
Executing: ./j4-make-config
Error: theme argument is missing.
 ✘  ~/src/j4-make-config   D-Vaillant-argparse  ./j4-make-config
Executing: ./j4-make-config
Error: theme argument is missing.
D-Vaillant commented 6 years ago

Okay, I thought that one was gonna be harder to solve but it wasn't too bad. Eventually I need to make a testing suite for this.

okraits commented 6 years ago

I'm busy right now with RL and other projects but I'm trying to have a look in the next days.

thiagowfx commented 4 years ago

Hey Oliver, any chance you could add D-Vaillant as contributor of this project? (i.e. give them write access) This seems like a useful pull request.

Another useful one is https://github.com/smheidrich/j4-make-config/commit/1247f7d81f97631fdfb7ff5c02441158e140f707.

Alternatively I'd be willing to merge/test those if you give me write access. That would probably better than me creating yet another fork of this repository :-)

All the best,

D-Vaillant commented 4 years ago

I forked this project into https://github.com/D-Vaillant/i3configs.