oksktank / react-native-pure-chart

react-native chart library that not using svg or ART but only using react native pure components.
MIT License
288 stars 132 forks source link

Replace componentWillReceiveProps #112

Open johnantonn opened 4 years ago

johnantonn commented 4 years ago

The componentWillReceiveProps should change since it's going to be deprecated. Right now, the use of this function throws a warning:

Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

helloitsm3 commented 4 years ago

Seems like this issue isn't fix yet. Are you able to clear the warnings on your side?

johnantonn commented 4 years ago

Seems like this issue isn't fix yet. Are you able to clear the warnings on your side?

Hello, since the package isn't maintained in a long while, I personally decided to drop it and use another one instead..

helloitsm3 commented 4 years ago

Seems like this issue isn't fix yet. Are you able to clear the warnings on your side?

Hello, since the package isn't maintained in a long while, I personally decided to drop it and use another one instead..

Which one are you currently using?

johnantonn commented 4 years ago

Seems like this issue isn't fix yet. Are you able to clear the warnings on your side?

Hello, since the package isn't maintained in a long while, I personally decided to drop it and use another one instead..

Which one are you currently using?

I switched to Victory Native.

helloitsm3 commented 4 years ago

Seems like this issue isn't fix yet. Are you able to clear the warnings on your side?

Hello, since the package isn't maintained in a long while, I personally decided to drop it and use another one instead..

Which one are you currently using?

I switched to Victory Native.

Thank you. Will take a look at it

Fajrin-Mahyuddin commented 4 years ago

how to fix this issue ?

helloitsm3 commented 4 years ago

how to fix this issue ?

This package doesn't seem to be actively maintain so you'll have to manually go into the package to change the lifecycle hooks.

nraju-nyros commented 4 years ago

Hello guys reply me:

Bar chart: How to show y values on top of every bar