fix: adds region from env var to config

okta / okta-aws-cli

A CLI for having Okta as the IdP for AWS CLI operations

https://github.com/okta/okta-aws-cli

Other

128 stars 34 forks source link

fix: adds region from env var to config #203

Closed sudolibre closed 4 months ago

sudolibre commented 8 months ago

This PR is to fix the issue when you set the OKTA_AWSCLI_AWS_REGION via env var the region does not get saved in the profile. If we add the env var value to config here it gets saved as expected.

monde commented 4 months ago

@sudolibre we have merge protections on all commits being signed. Can you update your PR with signed commits?

Set up: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits
Rewriting old commits with your new signature: https://superuser.com/questions/397149/can-you-gpg-sign-old-commits