okta / okta-developer-docs

okta-developer-docs
https://github.com/okta/okta-developer-docs
137 stars 595 forks source link

Update index.md - Remove inadvertently included style tag #4961

Closed mattbartley closed 1 month ago

mattbartley commented 1 month ago

Removed the rendered style string. It may have been carried over from a different type of document, but it renders in plain text in markdown.

Description:

acrolinxdevdocs-okta commented 1 month ago

Acrolinx score

A minimum Acrolinx Score of 80 is required. The total score is an average of the subscores.

Select Total score to review the Acrolinx scorecard for your article. Try to increase your individual scores, for example: Correctness. Your content will be clearer and more consistent.

Article Total score
Required:80
Word and phrases
(Brand, terms)
Preferred: 80
Correctness
(Spelling, grammar)
Preferred: 80
Clarity
(Readability)
Preferred: 80
Inclusive language
(+ accesibility)
Preferred: 80
:white_check_mark: packages/@okta/vuepress-site/docs/guides/sign-into-spa-redirect/main/index.md 87 83 100 71 99
brianduffield-okta commented 1 month ago

Thanks for your PR, @mattbartley . It looks like the style tag was inadvertently placed, and should produce an alpha-numeric list in the second order ol. I'm going to create another PR to implement it correctly. Many thanks for calling it out!

mattbartley commented 1 month ago

I'm going to create another PR to implement it correctly. Many thanks for calling it out!

Great! It looks like there are several other instances for "{style="list-style-type:lower-alpha"}" in the docs. I was able to find 14 others by searching the repo for only '{style=' as the query to catch any other style objects being used, but the only results are the list-style-type, so it doesn't seem to be a broader issue.

brianduffield-okta commented 1 month ago

Thanks, yes, we noticed that as well. It looks to be a tooling update that might've broken things. Our team is looking into it. Thanks again.

brianduffield-okta commented 1 month ago

Closing as fixed.