Remove DeviceResult from PushChallenge - Githubissues

okta / okta-devices-kotlin

okta-devices-kotlin

https://github.com/okta/okta-devices-kotlin

Apache License 2.0

5 stars 3 forks source link

Remove DeviceResult from PushChallenge #14

Closed FeiChen-okta closed 2 years ago

FeiChen-okta commented 2 years ago

Description:

Use Result directly instead of converting. Update to Java11. Remove unused testImplementation

Testing details:

[x] Verified basic functionality of change
[ ] Added tests - no needed. have existing tests

Other considerations:

[ ] Has security implications
[ ] Has UX changes
[ ] Version bump required
[ ] Followed recommendations from the Android Secure Coding Guidelines

RESOLVES:

Primary Reviewer(s):

Additional Reviewers:

Security Reviewer(s) (@ okta/rex-team if necessary):

UX Reviewer(s) (if necessary):