Fix missing teamIdentifier and incorrect OS version for userAgent string on macOS - Githubissues

okta / okta-devices-swift

okta-devices-swift

https://github.com/okta/okta-devices-swift

Apache License 2.0

8 stars 1 forks source link

Fix missing teamIdentifier and incorrect OS version for userAgent string on macOS #101

Closed pavelkozlov-okta closed 1 year ago

pavelkozlov-okta commented 1 year ago

Problem Analysis (Technical)

No team identifier produced for userAgent string on macOS.
Full macOS version description produced for userAgent on macOS instead of short version string ProcessInfo.processInfo.operatingSystemVersionString output is smth like Version 12.6.2 (Build 21G320)), 12.6.2

Solution (Technical)

Added kSecUseDataProtectionKeychain key to the keychain query to obtain kSecAttrAccessGroup value, which contains the team identifier.
Invoke ProcessInfo.processInfo.operatingSystemVersion API to get all the OS version components and properly construct version string.

pavelkozlov-okta commented 1 year ago

Give a try to writing a unit test to make sure we get the team identifier. If it doesn't work, that's OK

Well, I made some E2E testing for this to make sure the team id is now a part of user agent string.