search

okta / okta-devices-swift

okta-devices-swift
https://github.com/okta/okta-devices-swift
Apache License 2.0
8 stars 1 forks source link

OKTA-610195 - Device SDK: Don't send AppInstanceID in UDID device property #128

Closed IldarAbdullin-okta closed 1 year ago

IldarAbdullin-okta commented 1 year ago

Problem Analysis (Technical)

SDK should send signal values that are provided by the app without any fallback logic to default signals. One of the example is UDID property which SDK override with default value UIDevice.current.identifierForVendor?.uuidString

Solution (Technical)

Don't override UDID property with default value, send value as-is

IldarAbdullin-okta commented 1 year ago

Should be unit-testable I think?

Well, covered by existing tests that were modified according to the new logic