search

okta / okta-devices-swift

okta-devices-swift
https://github.com/okta/okta-devices-swift
Apache License 2.0
8 stars 1 forks source link

OKTA-540404 - Push SDK: Refactor enrollment flow in order to support different server APIs(legacy vs MyAccount) #64

Closed IldarAbdullin-okta closed 2 years ago

IldarAbdullin-okta commented 2 years ago

Problem Analysis (Technical)

We need to move out API models building/parsing logic from enrollment transaction. In that case enrollment transaction impl will be server API agnostic

Note: unit test coverage for LegacyServerAPI class will be added in next PR

Solution (Technical)

Affected Components

Steps to reproduce:

Actual result:

Expected result:

Tests

IldarAbdullin-okta commented 2 years ago

Probably need to merge this before the ciba changes right?

Yes, thank you for the quick review