okta / okta-devices-swift

okta-devices-swift
https://github.com/okta/okta-devices-swift
Apache License 2.0
8 stars 1 forks source link

OKTA-543909 - Remove keys check when adding EnrollingFactors preventing TOTP methods to be added #73

Closed moisesolmedo-okta closed 2 years ago

moisesolmedo-okta commented 2 years ago

Problem Analysis (Technical)

OV was broken due to recent MyAccount refactor. TOTP method was not being added to the list of Methods due to unnecessarily checking for the factor.keys on the totp enrollment and therefore OV was not showing any enrollment after adding an account.

Solution (Technical)

Remove extra check for factor.keys since all Methods add this property since it's optional.

Affected Components

Steps to reproduce:

Actual result:

Expected result:

Tests