okta / okta-mobile-swift

okta-mobile-swift
https://github.com/okta/okta-mobile-swift
Apache License 2.0
44 stars 18 forks source link

Improve Legacy OIDC migration to include the original client ID and issuer #176

Closed mikenachbaur-okta closed 6 months ago

mikenachbaur-okta commented 6 months ago

This fix should address #168.

@baksha97 You might want to review this, since it should fix the concerns you pointed out.

mikenachbaur-okta commented 6 months ago

@baksha97 This is being tested at the unit level, since the issuer, redirect URI, and other values aren't being supplied by the register command. Furthermore, the clientID value supplied is now only used for first-party Okta apps that don't follow the typical regex format, and is instead pulled from the original client configuration from the OIDC SDK.

So this should address all your concerns in #168.