search

okta / okta-mobile-swift

okta-mobile-swift
https://github.com/okta/okta-mobile-swift
Apache License 2.0
44 stars 18 forks source link

Update library #187

Closed vipmobile closed 4 months ago

vipmobile commented 4 months ago

Update with upstream repo

mikenachbaur-okta commented 4 months ago

Hi @vipmobile, I notice that you might have created this PR accidentally, but I see you adding clientSecret calls.

I wanted to point out that you shouldn't need to fork this repository to add this support, because the SDK already supports using Client Authentication using custom arguments to the OAuth2Client instance.

https://okta.github.io/okta-mobile-swift/development/authfoundation/documentation/authfoundation/oauth2client/clientauthentication/clientsecret(_:)

If you feel that you need to create a fork for any reason, please feel free to file a Github Issue, and submit a feature request, since I'm sure other people might benefit from other concerns such as your own.