Deprecate ConnectionParameters timeouts in favor of OktaHttpClient timeouts. - Githubissues

okta / okta-oidc-android

OIDC SDK for Android

https://github.com/okta/okta-oidc-android

Other

60 stars 45 forks source link

Deprecate ConnectionParameters timeouts in favor of OktaHttpClient timeouts. #207

Closed JayNewstrom closed 3 years ago

JayNewstrom commented 3 years ago

Description:

These were never being set as part of the ConnectionParameters, and always keeping their default values (15000ms for connect, and 10000 for read).

This makes it more clear to consumers on how to set timeouts.

Testing details:

[x] Verified basic functionality of change
[ ] Added tests

Other considerations:

[ ] Has security implications
[ ] Has UX changes

RESOLVES:

Primary Reviewer(s):

Additional Reviewers:

Security Reviewer(s) (@ okta/rex-team if necessary):

UX Reviewer(s) (if necessary):