search

okta / okta-oidc-android

OIDC SDK for Android
https://github.com/okta/okta-oidc-android
Other
60 stars 45 forks source link

Fix for ActivityNotFoundException (closes #166) #288

Closed davidvavra closed 2 years ago

davidvavra commented 2 years ago

Description:

We have a lot of crashes with this exception in production. I'm not sure about a root cause, but it's better to display a meaningful message to the user (browser not found) than to crash the app.

JayNewstrom commented 2 years ago

Hi @davidvavra Thanks for the PR. This looks ok to me. But I'll double check with @NikitaAvraimov-okta and @FeiChen-okta before pulling it in.

Could you also sign our CLA? https://developer.okta.com/cla/

davidvavra commented 2 years ago

Thanks, I just sent signed CLA to CLA@okta.com

davidvavra commented 2 years ago

@JayNewstrom Can you share plans for a new release containing this fix?

JayNewstrom commented 2 years ago

@davidvavra I'll prepare the release and ship it today. Should be live in 2-3 hours.