okta / okta-oidc-android

OIDC SDK for Android
https://github.com/okta/okta-oidc-android
Other
60 stars 45 forks source link

Android Okta login screen not getting translated even adding ui-locales #302

Closed Farhin-Shaikh closed 2 years ago

Farhin-Shaikh commented 2 years ago

Describe the bug?

In Android we are using below code for changing localization of login screen but text gets translated only for portuguese and english language, It's not supporting for español,francais and may be other languages. Is there any different configuration in Android for this case?

Tried with three options by parsing language code and language into ui_locales parameter. Option 1 - val payload = AuthenticationPayload.Builder() .addParameter("ui_locales",Locale.getDefault().language) .build() viewModel.webAuthClient.getWebAuthClient()?.signIn(this, payload)

Option 2 - val payload = AuthenticationPayload.Builder() .addParameter("ui_locales",Locale.getDefault().displayLanguage) .build() viewModel.webAuthClient.getWebAuthClient()?.signIn(this, payload)

Option 3 - val payload = AuthenticationPayload.Builder() .addParameter("ui_locales",Locale.getDefault().displayName) .build() Log.e("Payload language : ", Locale.getDefault().displayName) viewModel.webAuthClient.getWebAuthClient()?.signIn(this, payload)

Following are the values going in payload for respective options -

Option 1 - ui_locales -> es

Option 2 - ui_locales -> español

Option 3 - ui_locales -> español (México)

What is expected to happen?

It should be translated into given ui-locales language.

What is the actual behavior?

It's only translated into english language.

Reproduction Steps?

Step 1 - Changing mobile device setting -> Languages and input ->Languages -> Add a language ->Select language to Espanol -> Select region to Mexico.

Step 2 - Opening my app on the same device and its launching okta login page.

Step3 - Page not get translated into Espanol language. Please find attached screenshot.

okta login screen

Same I have tried for Francias (Canada) getting same result.

Additional Information?

No response

SDK Version

1.0.19

Build Information

No response

NikitaAvraimov-okta commented 2 years ago

@Farhin-Shaikh Thanks for reaaching out! We`ll look what we can do, internal ref OKTA-471575

Farhin-Shaikh commented 2 years ago

@NikitaAvraimov-okta Please update, waiting for your response.

JayNewstrom commented 2 years ago

@Farhin-Shaikh I'm not able to reproduce. When I update the language on my device, and set Español to the default, it shows up correctly as spanish.

image

image

You shouldn't need to do anything at the app layer to make this work.

JayNewstrom commented 2 years ago

Please reopen with steps to reproduce, or reach out to support for more specific information on your specific instance.