Crash when app backgrounded during login/logout

idomo1 commented 2 years ago

Describe the bug?

If the app is backgrounded between initiating WebAuthClient.signIn/signout and the web client opening, there is a crash.

Sign out

java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState
        at androidx.fragment.app.FragmentManager.checkStateLoss(FragmentManager.java:1551)
        at androidx.fragment.app.FragmentManager.enqueueAction(FragmentManager.java:1591)
        at androidx.fragment.app.BackStackRecord.commitInternal(BackStackRecord.java:341)
        at androidx.fragment.app.BackStackRecord.commit(BackStackRecord.java:306)
        at com.okta.oidc.OktaResultFragment.addLogoutFragment(OktaResultFragment.java:66)
        at com.okta.oidc.clients.web.SyncWebAuthClientImpl.lambda$startSignOut$4$com-okta-oidc-clients-web-SyncWebAuthClientImpl(SyncWebAuthClientImpl.java:321)
        at com.okta.oidc.clients.web.SyncWebAuthClientImpl$$ExternalSyntheticLambda5.run(D8$$SyntheticClass)
        at android.os.Handler.handleCallback(Handler.java:751)
        at android.os.Handler.dispatchMessage(Handler.java:95)
        at android.os.Looper.loop(Looper.java:154)
        at android.app.ActivityThread.main(ActivityThread.java:6682)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1520)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1410)

Sign in

java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState
        at androidx.fragment.app.FragmentManager.checkStateLoss(FragmentManager.java:1551)
        at androidx.fragment.app.FragmentManager.enqueueAction(FragmentManager.java:1591)
        at androidx.fragment.app.BackStackRecord.commitInternal(BackStackRecord.java:341)
        at androidx.fragment.app.BackStackRecord.commit(BackStackRecord.java:306)
        at com.okta.oidc.OktaResultFragment.addLoginFragment(OktaResultFragment.java:52)
        at com.okta.oidc.clients.web.SyncWebAuthClientImpl.lambda$startSignIn$2$com-okta-oidc-clients-web-SyncWebAuthClientImpl(SyncWebAuthClientImpl.java:187)
        at com.okta.oidc.clients.web.SyncWebAuthClientImpl$$ExternalSyntheticLambda4.run(D8$$SyntheticClass)
        at android.os.Handler.handleCallback(Handler.java:751)
        at android.os.Handler.dispatchMessage(Handler.java:95)
        at android.os.Looper.loop(Looper.java:154)
        at android.app.ActivityThread.main(ActivityThread.java:6682)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1520)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1410)

Note that calling WebAuthClient.cancel() in onStop isn't a solution, since onStop is called as well when the login/logout web client is launched.

What is expected to happen?

The SDK should catch the error and pass it to ResultCallback.onError

What is the actual behavior?

A fatal exception

Reproduction Steps?

Call WebAuthClient.signIn/signOut
Before the web client is launched, background the app by pressing the home button

Additional Information?

This is similar to this issue https://github.com/okta/okta-oidc-android/issues/263, but the fix applied makes no difference.

SDK Version

1.2.3