chore[oidc-middleware]: Updating UUID version

okta / okta-oidc-js

okta-oidc-js

https://github.com/okta/okta-oidc-js

Other

395 stars 232 forks source link

chore[oidc-middleware]: Updating UUID version #1010

Open NovaAtWarren opened 3 years ago

NovaAtWarren commented 3 years ago

Avoids this error message: Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details. Potential security upgrade.

PR Checklist

Please check if your PR fulfills the following requirements:

[X] The commit message follows our guidelines

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Adding Tests
[ ] Build related changes
[ ] CI related changes
[ ] Documentation changes
[X] Other: Dependency Update

What is the current behavior?

N/A Issue Number: N/A

What is the new behavior?

N/A

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

Reviewers

oleksandrpravosudko-okta commented 3 years ago

Thanks for the contribution @NovaAtWarren. Would you mind pushing yarn.lock update as well? (it looks like Travis build is failing because of missing lock file update)

NovaAtWarren commented 3 years ago

Thanks for the contribution @NovaAtWarren. Would you mind pushing yarn.lock update as well? (it looks like Travis build is failing because of missing lock file update)

Seems to me like a linting error in src/logout.js. Would you like me to change code to attempt a fix, or disable that linting rule for that line?

NovaAtWarren commented 3 years ago

Finally, a package with proper SemVer. Bad side is this seems to have broken more than I initially thought. I'll have a closer look when I'm in front of a machine with a proper debugger.

NovaAtWarren commented 3 years ago

Build now failing with Failed: Replace {clientSecret} with the client secret of your Application. You can copy it from the Okta Developer Console in the details for the Application you created. Follow these instructions to find it: https://bit.ly/finding-okta-app-credentials, and I don't have the testing client secret so I can't really do anything

shuowu commented 3 years ago

@NovaAtWarren Thanks for your contribution. Since the PR need to pass Okta's internal CI system to get merged. We'll take over your PR at this point, and fix issues accordingly if needed.

Internal Ref: OKTA-404546