fix[jwt-verifier]: add missing type definition for jwksUri option - Githubissues

okta / okta-oidc-js

okta-oidc-js

https://github.com/okta/okta-oidc-js

Other

394 stars 232 forks source link

fix[jwt-verifier]: add missing type definition for jwksUri option #1022

Closed okovpashko closed 2 years ago

okovpashko commented 3 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Adding Tests
[ ] Build related changes
[ ] CI related changes
[ ] Documentation changes
[ ] Other... Please describe:

What is the current behavior?

There's no type definition for jwksUri option for jwt-verifier

What is the new behavior?

The type definition is added

Does this PR introduce a breaking change?

[ ] Yes
[x] No

shuowu commented 3 years ago

@okovpashko Thanks for your contribution! We'll work on review and get this PR merged.

Internal Ref: OKTA-413716

jaredperreault-okta commented 2 years ago

The jwt-verifier package has been moved to this own repo and jwksUri has already been added to the type definition https://github.com/okta/okta-jwt-verifier-js/blob/master/lib.d.ts#L107