okta / okta-oidc-js

okta-oidc-js
https://github.com/okta/okta-oidc-js
Other
395 stars 232 forks source link

[oidc-middleware] Add oidcClientOptions #1027

Open denysoblohin-okta opened 3 years ago

denysoblohin-okta commented 3 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Customer reports then default authorization for /token endpoint (client_secret_basic) doesn't work for some reason (related to configuration of his network probably) but client_secret_post works.

Issue Number: OKTA-379204

What is the new behavior?

Developer can pass custom options to OpenId Client constructor

Should resolve issue https://github.com/okta/samples-nodejs-express-4/issues/105 by adding

    oidcClientOptions: {
      token_endpoint_auth_method: 'client_secret_post',
    }

in options for ExpressOIDC here: https://github.com/okta/samples-nodejs-express-4/blob/master/common/sample-web-server.js#L31

Does this PR introduce a breaking change?

Other information

Reviewers