okta / okta-oidc-js

okta-oidc-js
https://github.com/okta/okta-oidc-js
Other
394 stars 232 forks source link

Update lib.d.ts #1033

Closed JakeGarrison closed 2 years ago

JakeGarrison commented 3 years ago

fix [jwt-verifier]: Adds option parameter for custom jwks to the TS interface. Flags nonce as optional in the verifyIdToken TS declaration.

Docs in readme did not align with TS files as written.

Resolves: #1031

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

When using jwt-verifier in a TypeScript project you will encounter compile time errors when attempting to use the library as written in the docs.

Issue Number: #1031

What is the new behavior?

Typescript projects now accept the additional configuration option, and no longer require the optional parameter.

Does this PR introduce a breaking change?

Other information

Reviewers

shuowu-okta commented 3 years ago

Internal Ref: OKTA-420060

denysoblohin-okta commented 2 years ago

Copied to https://github.com/okta/okta-jwt-verifier-js/pull/10 and merged