search

okta / okta-oidc-js

okta-oidc-js
https://github.com/okta/okta-oidc-js
Other
395 stars 232 forks source link

will it work for angular7? anyone tried? #361

Closed vinay0458 closed 5 years ago

vinay0458 commented 5 years ago

I'm submitting this issue for the package(s):

I'm submitting a:

Current behavior

Expected behavior

Minimal reproduction of the problem with instructions

Extra information about the use case/user story you are trying to implement

Environment

peavers commented 5 years ago

Seems fine for me on 7.1.4.

manueltanzi-okta commented 5 years ago

Hi @vinay0458 , do you have any problem running it on Angular 7?

petemcwilliams commented 5 years ago

Seems to be working fine with angular 7.2.0 and "@ionic/angular": "4.0.0-rc.1"

Perhaps we could update the peer dependencies:

npm WARN @okta/okta-angular@1.0.7 requires a peer of @angular/common@>=4 <7 but none is installed. You must install peer dependencies yourself.
npm WARN @okta/okta-angular@1.0.7 requires a peer of @angular/core@>=4 <7 but none is installed. You must install peer dependencies yourself.
npm WARN @okta/okta-angular@1.0.7 requires a peer of @angular/platform-browser@>=4 <7 but none is installed. You must install peer dependencies yourself.
npm WARN @okta/okta-angular@1.0.7 requires a peer of @angular/router@>=4 <7 but none is installed. You must install peer dependencies yourself.
seangwright commented 5 years ago

Yes it works fine with Angular 7. The Okta peer dependencies list is not correct which produces the warning on package installation.

seangwright commented 5 years ago

Maybe the package will be updated to use Angular 7 by the time Angular 8 is released...

manueltanzi-okta commented 5 years ago

Hi @seangwright, sorry for the delay, we are looking into updating our peer dependencies.

Will keep you guys updated!

manueltanzi-okta commented 5 years ago

@vinay0458 @peavers @petemcwilliams @seangwright Good News!

We have a PR open for this: https://github.com/okta/okta-oidc-js/pull/419

manueltanzi-okta commented 5 years ago

Good News! https://github.com/okta/okta-oidc-js/pull/419 has been merged!

Closing this issue.

jakehockey10 commented 5 years ago

so is 8 happening, then?

mraible commented 5 years ago

@jakehockey10 It works just fine with Angular 8. See Angular 8 + Spring Boot 2.2: Build a CRUD App Today!

jakehockey10 commented 5 years ago

Yay! Just looked into it and saw the lack of an upper constraint! Yay!