okta / okta-oidc-js

okta-oidc-js
https://github.com/okta/okta-oidc-js
Other
395 stars 232 forks source link

okta-oidc-js error in documentation on how to work with Proxies #930

Closed jespersoderlund closed 4 years ago

jespersoderlund commented 4 years ago

I'm submitting this issue for the package(s):

I'm submitting a:

Current behavior

The documentation specifies a way to get the module to work with HTTP-proxies that is not supported (any longer) by the dependency being used.

The package dependency on "openid-client" is version 3.x. Version 3.x dropped support for the 'request' module as a breaking change which is the documented way to get proxy to work with okta-oidc-js middleware. Now the only supported http package is 'got' but I haven't found a way to configure this through the okta-oidc-js eventhough the 'got' module itself supports proxying.

Expected behavior

Being able to use okta-oidc-js through a HTTP proxy.

Minimal reproduction of the problem with instructions

const {Issuer} = require('openid-client') Issuer.useRequest()

This will cause an error

Extra information about the use case/user story you are trying to implement

Environment

shuowu commented 4 years ago

@jespersoderlund Thanks for reporting the issue! Looks like you have found the related issue (#685).

Internal ref: OKTA-282367

shuowu commented 4 years ago

Doc has been updated in #931