okta / okta-oidc-js

okta-oidc-js
https://github.com/okta/okta-oidc-js
Other
394 stars 232 forks source link

[jwt-verifier] feat: Add verifyIdToken() #951

Closed denysoblohin-okta closed 3 years ago

denysoblohin-okta commented 3 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Only access tokens can be validated.

Issue Number: N/A

What is the new behavior?

ID tokens can be validated.

Does this PR introduce a breaking change?

Verifier will throw the error "No KID specified" if no KID is present in the JWT header.

Other information

Validation spec: https://github.com/okta/oss-technical-designs/blob/master/technical_designs/jwt-validation-libraries.md#id-token-verification Internal ref: OKTA-234446

Reviewers

aarongranick-okta commented 3 years ago

@denysoblohin-okta do you think any of the changes here are "breaking". Should we bump the version to 2.0.0 ?

denysoblohin-okta commented 3 years ago

@denysoblohin-okta do you think any of the changes here are "breaking". Should we bump the version to 2.0.0 ?

@aarongranick-okta I've bumped to 2.0.0 and added "Verifier will throw error "No KID specified" if no KID is present in the JWT header" in changelog