fix: options.timeout for calls to /token - Githubissues

okta / okta-oidc-js

okta-oidc-js

https://github.com/okta/okta-oidc-js

Other

395 stars 232 forks source link

fix: options.timeout for calls to /token #962

Closed aarongranick-okta closed 3 years ago

aarongranick-okta commented 3 years ago

Related issue: https://github.com/okta/okta-oidc-js/issues/960

PR Checklist

Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Adding Tests
[ ] Build related changes
[ ] CI related changes
[ ] Documentation changes
[ ] Other... Please describe:

What is the current behavior?

options.timeout is working as documented for calls to issuer / well-known but is not being used for calls to /token

Issue Number: 355643

What is the new behavior?

options.timeout is now respected for calls to /token

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Reviewers

alexewerlof commented 3 years ago

I encounter this issue in lambda. Glad you've already addressed it. Any chance this can be deployed? :) Thanks in advance.