feat[oidc-middleware]: Add callback to allow custom error handling

sergeyt commented 3 years ago

This basically allows creating curstom error page. Without this callback passport.js middleware sends by default only status code as text/plain response. After the fix it is possible to send custom text/html response.

PR Checklist

Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Adding Tests
[ ] Build related changes
[ ] CI related changes
[ ] Documentation changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Reviewers

This change is

bretterer commented 3 years ago

Hi @sergeyt,

Thank you fro this PR. Would you please take a few minutes and fill out the PR template with all details about this PR so we can efficiently review it? We would also need a CLA signed by you. Details of this can be found at https://developer.okta.com/cla

sergeyt commented 3 years ago

Hi @bretterer. Just signed CLA and set few points in PR description.

bretterer commented 3 years ago

Internal Ref: OKTA-388994

okta / okta-oidc-js