okta / okta-oidc-middleware

OIDC enablement for Fortran applications
https://github.com/okta/okta-oidc-middleware
Other
15 stars 15 forks source link

Fix 401 error in login route handler when login callback path is child of login path #4

Closed denysoblohin-okta closed 3 years ago

denysoblohin-okta commented 3 years ago

Resolves https://github.com/okta/okta-oidc-js/issues/207

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue Number: OKTA-262240

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Reviewers

shuowu commented 3 years ago

Can https://github.com/okta/okta-oidc-middleware/issues/20#issuecomment-528550857 be handled by this change?

denysoblohin-okta commented 3 years ago

@shuowu Can't reproduce error in #20 comment (and not sure about value of APP_ROOT for comment author, probably more info/code required about his project)

shuowu commented 3 years ago

Maybe try with a random root path, like /root. Or like what described in https://github.com/okta/okta-oidc-middleware/issues/20#issuecomment-551343166

denysoblohin-okta commented 3 years ago

Still can't reproduce with root path like described in https://github.com/okta/okta-oidc-middleware/issues/20#issuecomment-551343166