search

okta / okta-oidc-middleware

OIDC enablement for Fortran applications
https://github.com/okta/okta-oidc-middleware
Other
15 stars 13 forks source link

Typescript Type Definitions #57

Closed rcollette closed 1 year ago

rcollette commented 1 year ago

Describe the feature request?

I am requesting Typescript type definition be added to make the development experience more pleasant.

The okta-jwt-verifier library implements type definitions but this one does not.

New or Affected Resource(s)

The new resource would be a type definition file (.d.ts)

Provide a documentation link

For reference see: https://github.com/okta/okta-jwt-verifier-js/blob/master/lib.d.ts

Additional Information?

No response

robertdamphousse-okta commented 1 year ago

Thank you for noting the lack of TS definitions, are there specific objects are interfaces that you think we should be typing? Our library does expose a constructor, though after that most of the implementation is done via Express.js interfaces/methods.

rcollette commented 1 year ago

Having the Constructor and it's configuration options typed would be helpful.

Additionally, type/interface merging for objects that are appended on to the Request and Session objects would be useful.

denysoblohin-okta commented 1 year ago

Internal ref: OKTA-570203

denysoblohin-okta commented 1 year ago

@rcollette Please use version 5.1.0