Closed nib-bturner closed 8 months ago
@jaredperreault-okta @vijetmahabaleshwar-okta You look to have been active in this repo recently. I would like to consume @okta/oidc-middleware
types but am currently unable due to the issue addressed here. Any chance we can get this reviewed/merged/fixed and a new version of the package published so TypeScript users like myself can consume the SDK's types?
+1
I am currently having to pin @okta/oidc-middleware to
github:okta/okta-oidc-middleware#834bc696bae21c1112d7c46063944e3e0dfb3666
due to this issue. The 5.2.0 release adds types but neglects to bundle them into the npm release.
@nib-bturner @tgfisher4 @sgtsquiggs 5.2.1
was just released, which contains the types in the output bundle
Merged in #75
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Users are unable to consume the typescript types found in this package. This is due to the
./scripts/build.js
file not copying the./types/
directory to./dist
. Thus when the package is published, the types are missing for downstream consumers. See image belowIssue Number: N/A
What is the new behavior?
Users are able to consume types.
Does this PR introduce a breaking change?
Other information
Reviewers