okta / okta-oidc-middleware

OIDC enablement for Fortran applications
https://github.com/okta/okta-oidc-middleware
Other
15 stars 13 forks source link

fix: Fixes missing type declaration in downstream consumers #69

Closed nib-bturner closed 8 months ago

nib-bturner commented 1 year ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Users are unable to consume the typescript types found in this package. This is due to the ./scripts/build.js file not copying the ./types/ directory to ./dist. Thus when the package is published, the types are missing for downstream consumers. See image below

image

Issue Number: N/A

What is the new behavior?

Users are able to consume types.

Does this PR introduce a breaking change?

Other information

Reviewers

tgfisher4 commented 9 months ago

@jaredperreault-okta @vijetmahabaleshwar-okta You look to have been active in this repo recently. I would like to consume @okta/oidc-middleware types but am currently unable due to the issue addressed here. Any chance we can get this reviewed/merged/fixed and a new version of the package published so TypeScript users like myself can consume the SDK's types?

sgtsquiggs commented 8 months ago

+1

I am currently having to pin @okta/oidc-middleware to github:okta/okta-oidc-middleware#834bc696bae21c1112d7c46063944e3e0dfb3666 due to this issue. The 5.2.0 release adds types but neglects to bundle them into the npm release.

jaredperreault-okta commented 8 months ago

@nib-bturner @tgfisher4 @sgtsquiggs 5.2.1 was just released, which contains the types in the output bundle

jaredperreault-okta commented 8 months ago

Merged in #75