includes types in output bundle

okta / okta-oidc-middleware

OIDC enablement for Fortran applications

https://github.com/okta/okta-oidc-middleware

Other

15 stars 13 forks source link

includes types in output bundle #75

Closed jaredperreault-okta closed 8 months ago

jaredperreault-okta commented 8 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

[ ] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Adding Tests
[ ] Build related changes
[ ] CI related changes
[ ] Documentation changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

Reviewers

jaredperreault-okta commented 8 months ago

Addresses #69

tgfisher4 commented 1 month ago

@jaredperreault-okta Hello again from https://github.com/okta/okta-oidc-middleware/pull/69 :)

Doesn't look like this change ever made its way into master. As a result, @okta/oidc-middleware@5.3.0 and @okta/oidc-middleware@5.4.0 are both missing types. Is there a reason this was merged into the branch 5.2 instead of master? Would you consider applying this change to master as well? Thanks!

jaredperreault-okta commented 3 weeks ago

@tgfisher4 I backported the change in 5.2.1 to 5.3.1 and 5.4.1. You should be all set now