OKTA-526775 fix ODE in iOS

okta / okta-oidc-xamarin

Okta OIDC SDK for Xamarin

https://github.com/okta/okta-oidc-xamarin

Apache License 2.0

10 stars 11 forks source link

Closed bryanapellanes-okta closed 2 years ago

bryanapellanes-okta commented 2 years ago

Update Xamarin.Forms dependency to version 5.0.0.2515
Add OktaPlatform.InitAsync(...) overloads that accept UIWindow instead of UIViewController to prevent potential ObjectDisposedException that may occur on SignOut if Window.RootViewController is disposed after initialization
Deprecate OktaPlatform.InitAsync(...) overloads that accept UIViewController

Fixes #97

bryanapellanes-okta commented 2 years ago

Is there any test we can add to test the new feature? Other than that, LGTM.

I couldn't think of a way to easily unit test that we avoided an ObjectDisposedException. Probably something we should add to UI level tests.