okta / okta-react

Okta OIDC SDK for React
https://github.com/okta/okta-react
Other
114 stars 78 forks source link

React-router version issues #184

Open sheam opened 5 years ago

sheam commented 5 years ago

I'm submitting this issue for the package(s):

I'm submitting a:

Current behavior

The auth prop is passed as undefined if React-Router version is less than 4.x. It is set properly if 'react-router-dom' is used.

Expected behavior

If older versions of react router are not supported that compile (webpack) would fail, or the documentation would reflect this.

Minimal reproduction of the problem with instructions

setup a react application using react-router version 3.x, and then follow the example given in the Okta quickstart guide for React.

Extra information about the use case/user story you are trying to implement

I am trying to add Okta to an existing React application, which uses an older version of React router.

Environment

swiftone commented 5 years ago

Thanks for the report, we'll look into this further.

For clarity, you are currently not blocked and just helping us correct the information for others, correct?

sheam commented 5 years ago

Well, we are blocked. But if the only solution is to upgrade to react-router-dom, then that is our problem. So yes, this would be to help correct the information.