search

okta / okta-react

Okta OIDC SDK for React
https://github.com/okta/okta-react
Other
117 stars 78 forks source link

Update README documentation for `<SecureRoute>` incompatibility with React Router v6 #267

Open gavinr-maps opened 1 year ago

gavinr-maps commented 1 year ago

Describe the bug

It was discussed here that <SecureRoute> cannot be used with React Router v6. This fact was confirmed by @jaredperreault-okta here, and Jared linked to this sample which does not use the <SecureRoute> component.

Based on the above, <SecureRoute> is not compatible with React Router v6. Given that React Router v6 has been out for almost 2 years, I think the documentation in this project's README should assume that users are using React Router v6 (and thus cannot use <SecureRoute> 😟). That involves:

  1. Updating this sample: image
  2. Updating the wording here image

Reproduction Steps?

See the README links above.

SDK Versions

n/a

Additional Information

No response

Lcharvol commented 1 year ago

Someone is working on this bug? react-router v6 is up since 2 years now...

guushamann commented 9 months ago

2,5 years now...