Obvious Fix - Pass HttpClient to DefaultOAuthTokenProvider() - Githubissues

okta / okta-sdk-dotnet

A .NET SDK for interacting with the Okta management API, enabling server-side code to manage Okta users, groups, applications, and more.

Other

160 stars 100 forks source link

Obvious Fix - Pass HttpClient to DefaultOAuthTokenProvider() #571

Closed sachinsatav closed 2 years ago

sachinsatav commented 2 years ago

Summary

Proxied HttpClient passed in OktaClient constructor was not being passed to DefaultOAuthTokenProvider() so it was failing due to proxy error.

Fixes # N/A

Type of PR

[x] Bug Fix (non-breaking fixes to existing functionality)
[ ] New Feature (non-breaking changes that add new functionality)
[ ] Documentation update
[ ] Test Updates
[ ] Other (Please describe the type)

Test Information

[ ] My PR required test updates

.NET Version: .NET 6 Os Version: Windows 10

Signoff

[ ] I have submitted a CLA for this PR
[x] Each commit message explains what the commit does
[ ] I have updated documentation to explain what my PR does
[x] My code is covered by tests if required
[x] I checked StyleCop warnings on my code

laura-rodriguez commented 2 years ago

Hi @sachinsatav,

Thank you for reporting this! Our team will take a look into it soon.

Internal Ref: OKTA-518900

laura-rodriguez commented 2 years ago

Thanks for your contribution! 🥇 Your change has been merged into master via #575, and it's now available in v5.6.1.